U4-9209 - Nuget update for xdt removes the HtmlAgility assembly binding, but doesnt re-add it

Created by Mikkel Holck Madsen 21 Nov 2016, 21:25:02 Updated by Sebastiaan Janssen 21 Nov 2016, 21:55:07

When we are doing nuget upgrades and handles web.config, and the assemblyBindings section, we start by removing those elements we know we are shipping with, like Newtonsoft.Json and AutoMapper, and then we re-add them, in the version we ship with.

The re-adding part is wrong for the HtmlAgilityPack, which is missing the xdt:Transform="Insert" attribute, which ensures that the element is inserted. The current file just removes it, and doesnt do anything to the HtmlAgilityPack binding.

Comments

Mikkel Holck Madsen 21 Nov 2016, 21:25:34

PR here: https://github.com/umbraco/Umbraco-CMS/pull/1560


Sebastiaan Janssen 21 Nov 2016, 21:54:58

Good catch! Thanks!


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 7.5.5

Sprint: Sprint 47

Story Points:

Cycle: