U4-9222 - The in memory XML cache is cloned everytime there is a content save even if there is nothing published

Created by Shannon Deminick 25 Nov 2016, 17:05:50 Updated by Stephan 28 Nov 2016, 12:06:25

Tags: Unscheduled

The reason this happens is because the sort order of the xml cache needs to be updated in certain circumstances when content is saved, for example if something gets unpublished, the sort order would need to change in the xml cache.

However, in some circumstances, the sort order update makes no difference:

  • It's a brand new content item
  • it's sort order has not changed and it's published state has not changed

The main problem is that every time the xml cache is updated it's cloned which has a large overhead especially when there is a lot of content.

Comments

Shannon Deminick 25 Nov 2016, 17:08:47

PR: https://github.com/umbraco/Umbraco-CMS/pull/1636


Stephan 28 Nov 2016, 08:53:58

Have made a small change to the test in content.cs using HasPublishedVersion which is cheap and should tell us whether the node is in the XML cache at all or not. Otherwise, the rest is OK for me. Comments?


Stephan 28 Nov 2016, 12:06:20

merged ok


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 7.5.5

Sprint: Sprint 47

Story Points:

Cycle: