We have moved to GitHub Issues
Created by Marc Goodson 28 Dec 2016, 15:01:16 Updated by Sebastiaan Janssen 16 Jan 2017, 10:02:34Tags: PR
Talking to a group of editors before Christmas, one common annoyance raised was the 'You have unsaved changes' dialog. Essentially it is great - except editors are finding they are accidentally clicking 'Discard changes' instead of 'stay' when they mean to 'stay' - especially when they are not quite concentrating...
This has been mentioned to me before on the editor training courses, and I haven't given it much thought...
... I talked it over with this group of editors, and I think the issue maybe when you are not quite concentrating you click the 'emphasised' button 'Discard Changes' (even though it is coloured 'warning' orange) - and also in your mindset if you want to stay you actually 'Don't want to Change' 'and Don't Change is similar text to Discard Changes'...
With the order of the buttons, it's following the Windows pattern of OK / Cancel, and so from a readability perspective people should read 'Discard Changes' first and then the 'Stay' button text - but because these are non standard dialog terms, I think people's brains are not processing the options correctly (I wonder if the buttons said, 'Ok, Discard My Changes' and 'Cancel, Keep my changes' whether there would be less confusion) Probably never be able to test it.
Anyway in the meantime, should we add btn-success class to the 'stay' button option ? so it will get a green tinge and for the non colour blind editors they will get a visual clue this is the 'safe' option ?
Thanks, the PR is merged. I have made an extra commit where I removed the orange color on the "discard changes" button. It was a bit too colourful with the orange and green button side by side :)
Backwards Compatible: True
Fix Submitted: Pull request
Affected versions: 7.5.6
Due in version: 7.5.8
Sprint: Sprint 50
Story Points: 0.5