U4-9352 - Server side APIs for new Partial/Macro Views editor

Created by Niels Hartvig 09 Jan 2017, 10:24:28 Updated by Sebastiaan Janssen 20 Feb 2017, 13:06:21

Is required for: U4-9348

Parent for: U4-9356

Subtask of: U4-9272

Keep it in the 9348/9346 branch - depends a bit on U4-9353 - if we can combine them all that would be ideal. Similar thing might already exist for the templates editor.

Comments

Niels Hartvig 09 Jan 2017, 21:56:24

PR: https://github.com/umbraco/Umbraco-CMS/pull/1680


Niels Hartvig 09 Jan 2017, 21:56:46

Combined Scripts, Partial View and Partial View Macro into one controller


Niels Hartvig 19 Jan 2017, 08:51:39

Review notes:

  • Scripts, MacroPartials and Partial Views are hooked up
  • Saving and renaming works
  • Create and Delete are not wired up (pending new designs - a task for Sprint 51)

Known issues:

  • No icons in the tree
  • Issue with encoding of paths (for instance partial views -> /editors/xxxx.cshtml)


Mads Rasmussen 19 Jan 2017, 10:33:12

I will update here with my findings:

  • There is an issue with syncing of the tree (active state). The code object is missing a node path [-1, 1234] to be used to sync the tree.
  • Localise the editors. When this issue (http://issues.umbraco.org/issue/U4-9363) is merged into 7.6 it should just be copy pasting.
  • When you click a folder in the tree it tries to load it in the editor


Warren Buckley 19 Jan 2017, 13:48:01

@hartvig marking as re-opened due to some minor changes (see GitHub PR) need to be done to the code, but it's mostly copy/paste typos & fix up a failing unit test


Warren Buckley 23 Jan 2017, 08:28:21

I picked up some of the trivial bits from my review for @hartvig however ran out of time before sprint end to get this all fixed up fully.

But based on Mads notes still a couple bits to do. Let me know @hartvig if you intend to jump back on this or if you would like me to wrap up the loose ends with Mads on this one please?


Mads Rasmussen 27 Jan 2017, 09:54:40

@warren I have merged the PR so we can get all of these tasks closed. We have found the solution for the path and I have created a new issue for this: http://issues.umbraco.org/issue/U4-9441


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 7.6.0

Sprint: Sprint 51

Story Points: 2

Cycle: