U4-9371 - Examine indexes inherited unpublished nodes on index rebuild part 2

Created by Mads Krohn 12 Jan 2017, 08:24:23 Updated by Sebastiaan Janssen 17 Jan 2017, 09:05:33

Tags: Unscheduled

Relates to: U4-9395

Relates to: U4-9318

New ticket for the continuing problem of Examine indexing inherited unpublished nodes when rebuilding the External index.

1 Attachments

Download UmbracoExamine.dll

Comments

Shannon Deminick 12 Jan 2017, 23:47:21

PR: https://github.com/umbraco/Umbraco-CMS/pull/1683

for testing:

  • Create a few levels of documents
  • Publish them all
  • Rebuild the External index, validate that the correct number of published items are indexed
  • unpublish an item that contains children + descendants
  • Rebuild the External index, validate that the correct number of published items are indexed
  • Search by id in the examine dashboard on the external index for an document that is unpublished due to it's ancestor and verify it's not there

Make sure the new unit tests pass


Shannon Deminick 12 Jan 2017, 23:48:50

@sniffdk I've attached a drop in replacement DLL can you please verify it works as expected?


Mads Krohn 13 Jan 2017, 12:46:46

@Shandem yes, it's working as expected as far as I can tell, awesome !! :)


Devin Gleason Lambert 13 Jan 2017, 14:23:02

:) I have confirmed, from my example ( http://issues.umbraco.org/issue/U4-9318#comment=67-33968 ) that ExternalIndex does not detect my example unpublished node, nor its descendants. Thanks @Shandem, will you do another release for this?


Sebastiaan Janssen 16 Jan 2017, 10:09:04

There will be a v7.5.8 soon with this fix in it, thanks for the confirmations guys!


Mads Krohn 16 Jan 2017, 10:11:04

Awesome, thanks! :)


Shannon Deminick 17 Jan 2017, 05:34:24

@sebastiaan lol, this PR wasn't merged :P i'll merge it now


Sebastiaan Janssen 17 Jan 2017, 09:05:33

Duh.. sorry :)


Priority: Major

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 7.5.8

Sprint: Sprint 50

Story Points:

Cycle: