U4-9524 - TinyMCE floatpanel not being destroyed

Created by Lee Kelleher 13 Feb 2017, 18:31:26 Updated by Lee Kelleher 25 Mar 2017, 11:21:05

Tags: PR

Relates to: U4-8418

I'm not sure what version of Umbraco this issue appeared in, but have only noticed it in v7.5.6+ (My gut feeling is that it goes further back)

When a user selects the "Formats" dropdown on the RTE, this creates a "floatpanel" in the DOM. If the RTE is deleted/removed, the floatpanel still remains. See attached screen-capture video - example using the RTE in a Grid cell.


I tried digging into this, but couldn't figure out why TinyMCE isn't removing the floatpanel from the DOM, it must be an issue with the library itself.

I did find code in Umbraco that tries to work around this here: https://github.com/umbraco/Umbraco-CMS/commit/e9af8bfee1fb49fa9c966589eca63e9a562d647e

However, when the RTE is re-created, there are already multiple floatpanel elements in the DOM and the floatpanel.length is greater than 1. I'll send a patch to correct this.

1 Attachments

Download umb-mce-floatpanel.mp4

Comments

Lee Kelleher 13 Feb 2017, 18:43:57

Pull request submitted: https://github.com/umbraco/Umbraco-CMS/pull/1754

This doesn't fix the orphaned "floatpanel" elements in the DOM; it only works around the underlying issue.


Lee Kelleher 25 Mar 2017, 11:19:55

Closing this issue, as is resolved in U4-8418 ([PR #1793|https://github.com/umbraco/Umbraco-CMS/pull/1793]).


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.5.5, 7.5.6, 7.5.7, 7.5.8, 7.5.9

Due in version:

Sprint:

Story Points:

Cycle: