U4-9536 - If cmsDocument published or newest flags are duplicated (data corruption) our Repository Level should know how to deal with it

Created by Shannon Deminick 16 Feb 2017, 07:52:54 Updated by Stephan 02 Mar 2017, 10:18:10

Relates to: COU-519

Relates to: U4-9456

Subtask of: U4-9548

We're still investigating how this can be caused, currently it seems due to a specific chain of events + Courier. In any case, the Core can deal with the corrupt data in it's queries so that umbraco can continue operating as normal.


Shannon Deminick 16 Feb 2017, 07:55:37

WIP PR https://github.com/umbraco/Umbraco-CMS/pull/1758

(Dont merge!!!!

Stephan 16 Feb 2017, 17:34:12

In VersionableRepositoryBase, you do a comparison on VersionDate... I ''think'' but I am not sure that it is possible that two versions have the same version date, for some odd reason, and then I guess we should compare the IDs and that the one with the greater ID.

Other than that I ''think'' I follow what you've done and it looks good to me.

Lee Kelleher 20 Feb 2017, 09:55:34

@Shandem @zpqrtbnk The mention of VersionableRepositoryBase as ring an alarm bell, not sure if you've seen U4-9456?

Shannon Deminick 20 Feb 2017, 10:13:06

Thanks for the mention @leekelleher !

Shannon Deminick 24 Feb 2017, 03:18:48

PR is updated with some notes, https://github.com/umbraco/Umbraco-CMS/pull/1758

@zpqrtbnk will assign to you for review, this also fixes U4-9456

Stephan 02 Mar 2017, 10:18:05

Code review is green, all tests are green, all good. Merged.

Priority: Normal

Type: Bug

State: Fixed


Difficulty: Normal


Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 7.5.11

Sprint: Sprint 53

Story Points: 2