We have moved to GitHub Issues
Created by Claus Jensen 21 Feb 2017, 07:58:12 Updated by Claus Jensen 29 Mar 2017, 12:40:19Tags: Unscheduled
Relates to: deploy-193
Relations doesn't have a guid. Should have a "predictable" guid being generated from a combination of the node guids and the RelationType guid used in the relation. This is required for Deploy to work with relations.
@zpqrtbnk not sure if I've forgotten something .. not done with implementing in Deploy yet so something might come up - I just wanted to get this pushed since I'm not on Deploy/Core for the rest of the week.
Unit tests green
Reviewed the PR and all seems OK. I am not fully happy about this addition as a relation is fully identified already by its source, target and type. But Deploy has been built around the idea that an "artifact" (with a unique identifier) exists or not, adding support for the idea that "two (more?) artifacts may be related" would probably be a pain.
That being said - keeping this PR un-merged until we're done with deploy-193 and we know it works and we don't have to add more stuff to this PR. Just to avoid creating yet another alpha, etc.
So this issue remains in "review" state but unassigned, waiting for deploy-193.
On hold - we might do things differently in which case we don't want to merge that PR.
Killing this one as we won't be doing it this way whether or not the other PR works ;)
Backwards Compatible: True
Affected versions: 7.6.0
Due in version:
Sprint: Sprint 53