U4-9571 - Legacy icons look weird

Created by Daniel Andreasen 27 Feb 2017, 14:47:10 Updated by Shannon Deminick 24 May 2017, 08:00:27

Tags: PR

From tree.less:

.umb-tree li.current > div i.icon, .umb-tree li.current > div ins { color: white !important; background: @blue; border-color: @blue; }

The background attribute here, is overriding the background-position and background-repeat from hacks.less:

.legacy-custom-file { width: 16px; height: 16px; min-width: 20px; /* this ensure the icon takes up same space as font-icon (20px) */ display: inline-block; background-position: center center; background-repeat: no-repeat; }

How it looks: [file:UI.jpg]

Pull request: https://github.com/umbraco/Umbraco-CMS/pull/1768

2 Attachments

Comments

Daniel Andreasen 12 Apr 2017, 08:29:53

@devteam This may have been implemented in 7.5.12 - maybe I labelled it wrong and it didn't get put in automatically or something? Or maybe it wasn't implemented - please give it a quick look though as it could be a quick closure :)


Daniel Andreasen 28 Apr 2017, 09:16:12

ping @pploug


Bjarne Fyrstenborg 24 May 2017, 06:21:23

I see this issue on the selected node in v7.6.1, because background overwrite background-repeat and background-position.


Bjarne Fyrstenborg 24 May 2017, 06:24:40

It seems this PR is reverted in the source. https://github.com/umbraco/Umbraco-CMS/blob/9badb35c054ecc91630b69b1b6753c78427cb4a6/src/Umbraco.Web.UI.Client/src/less/tree.less#L52


Shannon Deminick 24 May 2017, 06:30:28

@Bjarne.Fyrstenborg can you make a new PR with the correct values and i'll merge in asap (and also update this task correctly)


Priority: Minor

Type: Cosmetics

State: Fixed

Assignee:

Difficulty: Easy

Category: UI

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.5.10, 7.6.1

Due in version: 7.6.2

Sprint:

Story Points:

Cycle: 1