U4-9586 - Remove async parameter from the filestream when saving content xml

Created by Niels Hartvig 02 Mar 2017, 09:31:03 Updated by Shannon Deminick 02 Mar 2017, 09:47:23

Tags: Unscheduled

Relates to: U4-6338

Relates to: U4-7712

Relates to: U4-9257

Subtask of: U4-9548

In some circumstances, it appears as though if you use the new FileStream ctor and specify useAsync: true, then proceed to use XmlWriter.Create (not specifying async = true) and then xml.WriteTo(xmlWriter) that thsi can cause FCN restart issues!

There is more investigation required as to the exact circumstance this is being caused in and it can very well be environment / OS specific since the async=true flag acts differently based on environment / OS.

The problem that occurs is an app domain restart due to FCN in which you will get logs such as:

Umbraco.Core.UmbracoApplicationBase - Application shutdown. Details: ConfigurationChange
_shutDownMessage=Overwhelming Change Notification in 
    HostingEnvironment initiated shutdown
    CONFIG change
    Change Notification for critical directories.
    Overwhelming Change Notification in bin
    Change Notification for critical directories.
    Overwhelming Change Notification in App_LocalResources
    CONFIG change
    CONFIG change
    CONFIG change
    CONFIG change
    Change Notification for critical directories.
    Overwhelming Change Notification in App_WebReferences
    CONFIG change
    CONFIG change
    Change Notification for critical directories.
    Overwhelming Change Notification in App_LocalResources
    Change Notification for critical directories.
    Overwhelming Change Notification in App_Code
    CONFIG change
    Change Notification for critical directories.
    Overwhelming Change Notification in App_LocalResources
    CONFIG change
    Change Notification for critical directories.
    Overwhelming Change Notification in App_GlobalResources
    Change Notification for critical directories.
    Overwhelming Change Notification in App_Browsers
    CONFIG change
    CONFIG change
    CONFIG change
    CONFIG change
    CONFIG change

Comments

Shannon Deminick 02 Mar 2017, 09:45:31

PR: https://github.com/umbraco/Umbraco-CMS/pull/1774


Priority: Major

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 7.5.11

Sprint: Sprint 53

Story Points:

Cycle: