U4-9587 - RebuildXmlStructures doesn't clear out stale data so there is unpublished or trashed items remaining in the xml table, xml data integrity check is misleading due to the media lookup

Created by Shannon Deminick 02 Mar 2017, 15:36:29 Updated by Stephan 06 Mar 2017, 13:52:05

Tags: Unscheduled Regression

Relates to: U4-9136

Subtask of: U4-9548

This is a regression issue based on previously fixing the rebuild xml structures queries to not timeout on large data sets.

The other issue is that the query used to perform the lookup for count of media items to compare with the xml table doesn't take into account the trashed state.


Shannon Deminick 02 Mar 2017, 16:30:07

PR: https://github.com/umbraco/Umbraco-CMS/pull/1776

  • This fixes the count to 200 (which was meant to be done on the interface in U4-9136
  • This fixes the xml integrity lookup for media to take into account a trashed state
  • This fixes the rebuild xml structures for both the media and content taking into account trashed (and published for content) and then removing anything that shouldn't be there - added tests
  • This doesn't change members because members have no trashed/published state

Stephan 03 Mar 2017, 12:54:12

all good except one comment on the PR

Stephan 03 Mar 2017, 13:48:25

and except two Rebuild_All_Xml_... tests that consistently fail.

Stephan 06 Mar 2017, 13:52:00

good now, merged.

Priority: Major

Type: Bug

State: Fixed


Difficulty: Normal


Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 7.5.11

Sprint: Sprint 54

Story Points: