We have moved to GitHub Issues
Created by Shannon Deminick 23 Mar 2017, 07:52:10 Updated by Shannon Deminick 29 Mar 2017, 07:06:42Tags: Unscheduled
Subtask of: UAASSCRUM-810
Your report will have a greater chance of being addressed if you can give us clear steps to reproduce the issue, please answer the following questions in as much detail as possible: What did you do?
What did you expect to happen?
What actually happened?
7.6 ends up doing /umbraco/backoffice/UmbracoApi/CodeFile/PostSave whereas 7.5 ended up doing /umbraco/create.aspx?nodeId=init&nodeType=partialViewMacros&nodeName=Partial%20%20View%20%20Macro%20%20Files - which ends up in PartialViewMacro.ascx checking for whether to create the macro or only the file - 7.6 does not even exposes the checkbox + uses the CodeFileController which has no support at all for creating macros.
That same controller is used for scripts, partial views & partial view macros, and only the latter can potentially create a macro. It's not used (yet) for Xslt. It only deals with files really, not sure I want to add macro concerns in there... Maybe a second MacroController of some sort and call both from JS?
Current status: have added the checkbox back, but the whole code editor is no JS based, does not seem to be any C# controller, so need to deal w/macros one way or another...
review: now, should be possible to tick a "create macro" box and then a macro is also created pointing to the file
only problem so far is that there's change tracking enabled on the fields in the dialog so when the dialog is closed it has the 'are you sure you want to navigate away' alert. I'll fix this up it's easy.
Backwards Compatible: True
Due in version: 7.6.0
Sprint: Sprint 55
Story Points: 3