U4-9704 - Sorting UDI media picker items, makes it store Int's

Created by Per Ploug 30 Mar 2017, 11:17:43 Updated by Shannon Deminick 24 May 2017, 05:41:14

Subtask of: U4-9609

Your report will have a greater chance of being addressed if you can give us clear steps to reproduce the issue, please answer the following questions in as much detail as possible: What did you do? Used the new UDI-Based media picker, selected 3 images, saved and display without issues. Sorted the items and saved, website explodes with "1234 is not a valid UDI"

What did you expect to happen? to save UDI's

What actually happened? it saved ints

What version of Umbraco are you using? 7.6 beta

What version of Umbraco Forms or Contour are you using?

1 Attachments

Comments

Paul Wright 02 May 2017, 15:02:01

This issue is in the production release.


Claus Jensen 03 May 2017, 08:22:53

The sorting method was not taking into account whether the config was set to UDI or not - always using integer ID when reassigning the ID values after sorting.

PR: https://github.com/umbraco/Umbraco-CMS/pull/1929


Claus Jensen 03 May 2017, 11:50:35

This has been merged .. will be part of 7.6.1 release but can also be found in this nightly build if a critical fix is needed before the next release: https://ci.appveyor.com/api/buildjobs/ja8wyiaji5ylfwwl/artifacts/build%2FUmbracoCms.7.6.0-build7398.zip


Paul Wright 03 May 2017, 14:03:00

Thank Claus!! - This is very critical for my particular project - so the nightly fix is most welcomed


Paul Wright 03 May 2017, 14:41:43

Tried that nightly, and still getting the same problem/Issue. Is that the right link?


Paul Wright 03 May 2017, 16:22:59

Managed to "bodge" it for the time being with a direct update on the umbraco.controllers.js file

It's only 1 line of code that needed changing


Claus Jensen 03 May 2017, 16:34:15

@suedeapple Yep the js file (and all the other controller js files) is compiled into that controllers.js file so it should be sufficient to just update that one. I just checked the zip and it does contain the fix - I think you may need to bump the clientdependency version number in clientdependency.config though, as you are most likely getting a cached version of all the backoffice javascript from before the nightly-update.

Happy to hear it's working for you though :)


Paul Wright 03 May 2017, 16:39:10

Ahhh - nightly does work - my bad!! ooops!


Priority: Major

Type: Bug

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.6.0

Due in version: 7.6.1

Sprint: Sprint 58

Story Points:

Cycle: 1