U4-9926 - Using Deploy - PartialView Macros generate UDIs incorrectly as PartialViews instead

Created by Warren Buckley 17 May 2017, 09:46:42 Updated by Warren Buckley 17 May 2017, 12:39:58

Tags: Unscheduled

The Umbraco Core File service returns partial view macro entities as IPartialView (same as a normal partial view) and that confuses Deploy giving it an incorrect UDI when doing restores.

As the manifest handshake identifies the Partial View Macro as a Partial View the hash/signature does not match

An example was found by @Shandem when trying to restore a simple content node with a RTE that includes a macro to a picked Form from a Cloud environment to his local machine.

Comments

Stephan 17 May 2017, 10:13:48

Deploy branch temp-u4-9926 implements a workaround that should fix the situation. Cms branch temp-u4-9926 fixes the situation for real in Cms.

Proposition is to apply Deploy branch asap, and then Cms branch during normal rollout, and ''then'' we should remember to remove the Deploy workaround - not that it's not compatible, but it's better to remove it.


Warren Buckley 17 May 2017, 10:33:58

I have tested the PR for Deploy patch so we can get this rolled out quicker on cloud than getting a new version of Core rolled out.

PR for the deploy temp fix https://github.com/umbraco/Umbraco-Deploy/pull/128

Code change reads fine & I have tested it by deploying the updated Umbraco.Deploy dll with this patch on my local clone site & pushed the DLL upto the Cloud & was then able to successfully able to restore the site on my local machine.

This is now merged in Deploy in the development branch ready for a next deployment onto Cloud.


Warren Buckley 17 May 2017, 12:39:40

The Core PR for this is here that @zpqrtbnk created https://github.com/umbraco/Umbraco-CMS/pull/1949

I have read through the code changes and they all seem fine, checked the creation of partial view macros & partial views and they all work fine.

I patched my test site before I applied the deploy patch above and verified it was broken again & unable to restore from Cloud to local. Apply the patched DLLs from this PR Umbraco.dll & Umbraco.Core.Dll & pushed it up to cloud allowed for the restore to work successfully.


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.6.0, 7.6.1

Due in version: 7.6.2

Sprint: Sprint 59

Story Points:

Cycle: