U4-9931 - After 7.6.1 upgrade, tinyMCE can't load formats

Created by Eric Schrepel 17 May 2017, 21:54:15 Updated by Gary Hammett 09 Jul 2018, 11:01:09

Did NuGet upgrade from 7.5.13 to 7.6.1, now can't get Formats from RichText editor datatype. I get this error in Dev console when I click "Formats" from the TinyMCE menu. Did re-build, hard cache reload, recycle app pool, re-save Styles from UI menu, etc.

Uncaught TypeError: Cannot read property 'parentsRequired' of undefined at a (umbraco/lib/tinymce/tinymce.min.js?umb__rnd=7.6.1.1132724685:6) at s (umbraco/lib/tinymce/tinymce.min.js?umb__rnd=7.6.1.1132724685:6) at r (umbraco/lib/tinymce/tinymce.min.js?umb__rnd=7.6.1.1132724685:6) at Object.s [as getCssText] (umbraco/lib/tinymce/tinymce.min.js?umb__rnd=7.6.1.1132724685:6) at Object.A [as getCssText] (umbraco/lib/tinymce/tinymce.min.js?umb__rnd=7.6.1.1132724685:7) at textStyle (umbraco/lib/tinymce/tinymce.min.js?umb__rnd=7.6.1.1132724685:13) at t.postRender (umbraco/lib/tinymce/tinymce.min.js?umb__rnd=7.6.1.1132724685:14) at t.postRender (umbraco/lib/tinymce/tinymce.min.js?umb__rnd=7.6.1.1132724685:8) at t.<anonymous> (umbraco/lib/tinymce/tinymce.min.js?umb__rnd=7.6.1.1132724685:8) at Object.n [as each] (umbraco/lib/tinymce/tinymce.min.js?umb__rnd=7.6.1.1132724685:3)

3 Attachments

Download tinyMceConfig.config

Comments

Sebastiaan Janssen 19 May 2017, 07:29:31

Looks like tinyMce.config needs a bit of an update:

In <plugins> add:

<plugin loadOnFrontend="true">umbracolink</plugin>

And in the list of validElements this:

<![CDATA[+a[id|style|rel|data-udi|rev|charset|hreflang|dir|lang|

has turned into this:

<![CDATA[+a[id|style|rel|data-id|data-udi|rev|charset|hreflang|dir|lang|

I'll make sure that the upgrade instructions get updated.

Unfortunately we can't automatically update your config file with the last change as a config transform would replace the whole validElements section, which could already be customized by some people.


Eric Schrepel 19 May 2017, 17:17:36

Still getting the same error after editing the tinyMceConfig.config (which I've attached just in case there's something else amiss). Only happens when you click "Formats". Tried to screen cap the error also.


Sebastiaan Janssen 20 May 2017, 08:24:14

Config looks good. I tried to repro on a clean install of 7.6.1 but don't see any problem with formats.

Make sure that all files in the Umbraco & Umbraco_Client folder are updated too and that you've updated the version in clientdependency.config to update browser caches.


Eric Schrepel 14 Jun 2017, 20:18:26

Figured it out; my tinymce.css stylesheet (which gets updated when adding child stylesheets in the UI) had some badly formed CSS in it, resulting from a mis-named Alias:

/**umb_name:Large heading*/ largeHead {font-size:1.5em}

Should have been

/**umb_name:Large heading*/ .largeHead {font-size:1.5em}

My fault for sure, but would be awesome if, when adding child stylesheets, it could do a quick "CSS verify" to ensure both the Alias (that was my error) and CSS are valid before saving, because tracking down that error via Dev Console was tricky.


Matthew 03 Nov 2017, 13:39:03

This is still an issue with a clean install (Nuget) of Umbraco 7.7.4

EDIT: As Eric indicated, this had to do with the RTE not recognizing a rule in the stylesheet. I renamed small to .small and all is well. It's just odd because small is a valid HTML element, just not according to the tinyMce validElements configuration.


Gary Hammett 09 Jul 2018, 09:37:45

Matthew can you share what change you made; we have the same problem.

Same version as you, unlike Eric, we dont have the problem with ".largeHead" or ".small". So not sure where I can look from here.

How did you find that was the problem?

Just replaced the minified version with a non production file to find I might have a problem with the code element. Update soon.


Gary Hammett 09 Jul 2018, 11:01:09

Our problem was with configuration.

We didn't include "-code" in the validElements for the tinymce config.

Not tested on a clean install, so cannot confirm if this happens for everyone.


Priority: Normal

Type: Bug

State: Can't Reproduce

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.6.0, 7.6.1, 7.7.4

Due in version:

Sprint:

Story Points:

Cycle: