U4-9934 - Delete on list view with custom membership provider deletes top member in list

Created by Callum Whyte 18 May 2017, 21:28:40 Updated by Sebastiaan Janssen 17 Jul 2017, 20:06:40

Tags: PR

Subtask of: U4-9609

We have a site running the latest Umbraco v7.5.14 with a custom ASP.NET membership provider (rather than an Umbraco Membership Provider).

The membership provider uses Guids for ids meaning the ID Umbraco uses for each of our members is just int.MaxValue (2147483647). This has caused some issues with the backoffice in the past which have been fixed - see U4-9042 where a change was made to rely on the member Key (our Guid) in cases where the member Id was the default value 2147483647.

Currently when trying to delete a member via the backoffice in the list view Umbraco simply deletes the first member in the list, rather than the selected member. As a result, it is very easy to accidentally delete the wrong member!

Upon investigation it would appear this happens because on delete the code fetches the Key property from the member by it's Id (which is always '2147483647' and therefore selects the top member in the list).

Comments

Callum Whyte 18 May 2017, 22:02:04

I have created a pull request containing my proposed fix for the issue: https://github.com/umbraco/Umbraco-CMS/pull/1952

Feedback is welcome!

Cheers, Callum


Sebastiaan Janssen 17 Jul 2017, 20:04:34

Great work Callum, does what it says on the tin!

You know have the coveted Core Contributor badge on your Our profile: https://our.umbraco.org/member/152036

Thanks for the PR!


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.5.3, 7.5.4, 7.5.5, 7.5.6, 7.5.7, 7.5.8, 7.5.9, 7.5.10, 7.5.11, 7.5.12, 7.5.13, 7.5.14

Due in version: 7.6.5

Sprint: Sprint 63

Story Points:

Cycle: 3